snitch-org / snitch

Lightweight C++20 testing framework.
Boost Software License 1.0
259 stars 7 forks source link

Rename `small_function` to `function_ref` #131

Closed tocic closed 1 year ago

tocic commented 1 year ago

Closes #112.

codecov[bot] commented 1 year ago

Codecov Report

Merging #131 (0d30d09) into main (c0a910c) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cschreib/snitch/pull/131/graphs/tree.svg?width=650&height=150&src=pr&token=X422DE81PN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber)](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber) ```diff @@ Coverage Diff @@ ## main #131 +/- ## ======================================= Coverage 93.67% 93.67% ======================================= Files 27 27 Lines 1597 1597 ======================================= Hits 1496 1496 Misses 101 101 ``` | [Files](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber) | Coverage Δ | | |---|---|---| | [include/snitch/snitch\_cli.hpp](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber#diff-aW5jbHVkZS9zbml0Y2gvc25pdGNoX2NsaS5ocHA=) | `100.00% <ø> (ø)` | | | [include/snitch/snitch\_function.hpp](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber#diff-aW5jbHVkZS9zbml0Y2gvc25pdGNoX2Z1bmN0aW9uLmhwcA==) | `100.00% <100.00%> (ø)` | | | [include/snitch/snitch\_registry.hpp](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber#diff-aW5jbHVkZS9zbml0Y2gvc25pdGNoX3JlZ2lzdHJ5LmhwcA==) | `82.85% <ø> (ø)` | | | [src/snitch\_cli.cpp](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber#diff-c3JjL3NuaXRjaF9jbGkuY3Bw) | `81.13% <ø> (ø)` | | | [src/snitch\_error\_handling.cpp](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber#diff-c3JjL3NuaXRjaF9lcnJvcl9oYW5kbGluZy5jcHA=) | `0.00% <ø> (ø)` | | | [src/snitch\_registry.cpp](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber#diff-c3JjL3NuaXRjaF9yZWdpc3RyeS5jcHA=) | `94.88% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber). Last update [c0a910c...0d30d09](https://app.codecov.io/gh/cschreib/snitch/pull/131?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Corentin+Schreiber).
tocic commented 1 year ago

Seems like I don't have the rights to merge. There's no "Merge pull request" button in the UI, and this is my cmd output:

$ git push -vv
Pushing to github.com:cschreib/snitch.git
Enter passphrase for key '/home/tocic/.ssh/github_tocic':
ERROR: Permission to cschreib/snitch.git denied to tocic.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
cschreib commented 1 year ago

I see, looks like you'd need to be formally invited as collaborator before you are able to do this. I've opened a ticket to discuss the topic (https://github.com/cschreib/snitch/issues/132), please chime in there if you have an opinion. In the meantime I will merge this myself, thanks for your contribution!