snitch-org / snitch

Lightweight C++20 testing framework.
Boost Software License 1.0
252 stars 7 forks source link

Add a logo #137

Closed cschreib closed 9 months ago

cschreib commented 9 months ago

The newly created snitch organization needs a logo, to replace the boring and randomly-generated standard GitHub avatar. After a little bit of research, I selected a eurasian jay feather as symbol of the project. The rationale is:

The logo in this PR was created from scratch in Inkscape, using real feathers as models. I'm no artist, but I'm pleased with the result!

logo-big

codecov[bot] commented 9 months ago

Codecov Report

Merging #137 (8a2805e) into main (5e16ce5) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/snitch-org/snitch/pull/137/graphs/tree.svg?width=650&height=150&src=pr&token=X422DE81PN&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snitch-org)](https://app.codecov.io/gh/snitch-org/snitch/pull/137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snitch-org) ```diff @@ Coverage Diff @@ ## main #137 +/- ## ======================================= Coverage 93.67% 93.67% ======================================= Files 27 27 Lines 1597 1597 ======================================= Hits 1496 1496 Misses 101 101 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/snitch-org/snitch/pull/137?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snitch-org). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snitch-org) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/snitch-org/snitch/pull/137?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snitch-org). Last update [5e16ce5...8a2805e](https://app.codecov.io/gh/snitch-org/snitch/pull/137?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snitch-org). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snitch-org).
tocic commented 9 months ago

Wow, looks cool! There's a common problem, though - it looks different if you use the dark theme. In this particular case there's not much difference, but idk if this is expected. See https://github.com/catchorg/Catch2/issues/2573, for example :). Maybe it's worth changing the background here too.

image

image

cschreib commented 9 months ago

The difference between light and dark is pretty much what I expect! I have designed the logo with the dark theme in mind, but I did add the black outlines to the text and feather icon to make sure it would render OK regardless of the background color.

That being said, I now see that, with the light theme, the bottom border of the feather is cut by the GitHub box border. I'll add a bit more margins to prevent that.

Edit (also added a couple notches at the top of the feather, to make it more obvious that it is a feather): image image

cschreib commented 9 months ago

Thanks for reviewing this, and sorry I keep pushing updates, I have no other way to check how it looks in the main page...

cschreib commented 9 months ago

That's the one! Thanks for the feedback ;)