snitch-org / snitch

Lightweight C++20 testing framework.
Boost Software License 1.0
267 stars 10 forks source link

--color vs. --colour-mode #155

Closed vid512 closed 10 months ago

vid512 commented 10 months ago

Snitch command line options seem to be mixing US and british spelling of color vs. colour, in option names --color and --colour-mode. Descriptions of parameters always use spelling "color". Is there any historical reason for this, or just an oversight? It would make sense to stick to single spelling.

Maybe add --color-mode as preferred synonym to --colour-mode, and keep --colour-mode only for backwards compatibility?

cschreib commented 10 months ago

It is historical yes, but there is a logic to it. The UK spelling version is provided for command-line compatibility with Catch2 (which allows snitch to use the exact same IDE integrations, so is very important). The snitch native command-line, instead, uses US spelling, which is more prominent in software APIs hence least surprising.

Edit before someone overreacts: I'm French; you wouldn't want to have to type --mode-couleur=jamais, would you? ;)

cschreib commented 10 months ago

Closing this as a question, please re-open if you think we still need to do something about it.