Closed cschreib closed 1 year ago
Merging #84 (1eebf1d) into main (2800a42) will decrease coverage by
0.37%
. The diff coverage is92.92%
.
The failure of the WebAssembly Debug build is, I believe, a bug in Node.js/V8. I opened a ticket there to report the issue.
Options:
--liftoff-only
. I'm not happy with this, because that's probably not how people are going to run the code.I went with option 3, since it was the lowest effort and allows me to move on. Ultimately I'd want to go for option 5, but we'll have to wait for more widespread exception support. Until then, Emscripten + Node.js seems to be the most well-supported way to run C++ WASM code.
Ignoring the loss of coverage :)
This PR does the following:
snitch.hpp
into multiple header files andsnitch.cpp
into multiple sources files. Both files still exist, and include the other files, so this is backward-compatible. This move allows us to preserves the "unity build" approach from before, which yields better full build times. But now, an alternative non-unity build is possible, where each source file is compiled independently. This provides better incremental build time. Another motivation for this was that the source code has tripled in size since v0.1, and having all the code in a single file was getting harder to manage.The WebAssembly Debug build in CI no longer runs Doctest, because this is triggering a bug in Node.js/V8. See below for more information.