search

snitch3s / hackbunch

Hacktoberfest tracker for your community.
MIT License
11 stars 5 forks source link

Made the front end using bootstrap 4 #12

Closed SkaarFacee closed 5 years ago

SkaarFacee commented 5 years ago

Developed the front end using bootstrap 4 and added some animations. Fixes #3. @vchrombie You can also add some new images if needed. If you have any ideas, please suggest.

vchrombie commented 5 years ago

Can you remove the bootstrap files and maybe use an online CDN for bootstrap?

vchrombie commented 5 years ago

Developed the front end using bootstrap 4 and added some animations. Fixes #3 . @vchrombie You can also add some new images if needed.If you have any ideas, please suggest

And this is wrong. Headings are meant to be different apart from the normal paragraphs. Please edit this.

vchrombie commented 5 years ago

Still, you have use CDN instead of adding a few more files. Maybe you can use cdnjs.com to handle all such imports.

vchrombie commented 5 years ago

@adiaux There are still a few alien files in the PR. Take time and finish it. Make sure your PR has the correct files which are supposed to be there.

vchrombie commented 5 years ago

Add commits to the same PR. You can squash the commits in the last after I approve.

SkaarFacee commented 5 years ago

Sent a new PR

vchrombie commented 5 years ago

Please resolve all the comments when you solve them and are expired.

vchrombie commented 5 years ago

Add commits to the same PR. You can squash the commits in the last after I approve.

Also, remember this.

vchrombie commented 5 years ago

And one more thing, you fixed the query issue thing in this PR. Make sure you address the different issues in different PRs.

SkaarFacee commented 5 years ago

Query issue still persists, working on it right now

vchrombie commented 5 years ago

Query issue still persists, working on it right now

Better you send a new PR for that. Maybe create a new branch from the master and fix the problem in that branch. Let this PR deal with only the front-end.

SkaarFacee commented 5 years ago

Just made a new commit to simplify the code

vchrombie commented 5 years ago

LGTM, merging it right away. Thanks for the PR, @adiaux. :tada: