search

snitch3s / hackbunch

Hacktoberfest tracker for your community.
MIT License
11 stars 5 forks source link

Added support for command line flags #23

Closed SkaarFacee closed 5 years ago

SkaarFacee commented 5 years ago

Made the code work using command line flags, like 

python3 script.py -u username
python3 script.py -t textfile.txt

Fixes #22 . Suggest if any changes are needed @vchrombie

vchrombie commented 5 years ago

@adiaux The code looks perfectly fine. But is the dummy data really needed?

SkaarFacee commented 5 years ago

@vchrombie Just updated it for reference, if it is unnecessary I can take it down anytime :)

vchrombie commented 5 years ago

@adiaux, it just messes up the repo. Remove all the changes related to data.txt and change the commit message and PR title, description. Let me know if you need any help. :slightly_smiling_face:

SkaarFacee commented 5 years ago

@vchrombie ,do you want me to remove the updates in data.txt or just remove that file as a whole ?

vchrombie commented 5 years ago

change the commit message

Squash the commits so that you can do this at that time itself.

vchrombie commented 5 years ago

@vchrombie ,do you want me to remove the updates in data.txt or just remove that file as a whole ?

Just remove the updates you did in this PR.

SkaarFacee commented 5 years ago

@vchrombie ,Undid those updates and changed the commit message :taco:

vchrombie commented 5 years ago

Also update the PR title, description.

SkaarFacee commented 5 years ago

Okay

vchrombie commented 5 years ago

LGTM now. Merging it. :tada: