search

snl-dakota / dakota-packages

The core TPL repo
0 stars 6 forks source link

Install directory for third party dependencies is hardcoded #3

Open StefanBruens opened 1 year ago

StefanBruens commented 1 year ago

most TPLs are installed with install(... DESTINATION lib).

e.g.: https://github.com/snl-dakota/dakota-packages/blob/95dbce9d761abbeb84cc86dda56ed5d8c7e29380/ampl/CMakeLists.txt#L157 https://github.com/snl-dakota/dakota-packages/blob/95dbce9d761abbeb84cc86dda56ed5d8c7e29380/acro/tpl/tinyxml/CMakeLists.txt#L18

For many Linux distributions this is incorrect, as 64 bit libraries should go into /usr/lib64/.

The correct approach is to use CMAKE_INSTALL_LIBDIR from GNUInstallDirs.

StefanBruens commented 1 year ago 
[ 3345s]    /usr/lib/cmake/FSUDace/FSUDaceConfig.cmake
[ 3345s]    /usr/lib/cmake/NCSUOpt/NCSUOptConfig.cmake
[ 3345s]    /usr/lib/cmake/ddace/ddace-config.cmake
[ 3345s]    /usr/lib/cmake/nidr/nidr-config.cmake
[ 3345s]    /usr/lib/lib3po.so
[ 3345s]    /usr/lib/libamplsolver.so
[ 3345s]    /usr/lib/libapproxnn.so
[ 3345s]    /usr/lib/libcolin.so
[ 3345s]    /usr/lib/libconmin.so
[ 3345s]    /usr/lib/libcport.so
[ 3345s]    /usr/lib/libdakota_dll_api.so
[ 3345s]    /usr/lib/libdakota_src.so
[ 3345s]    /usr/lib/libdakota_src_fortran.so
[ 3345s]    /usr/lib/libdakota_surrogates.so
[ 3345s]    /usr/lib/libdakota_util.so
[ 3345s]    /usr/lib/libddace.so
[ 3345s]    /usr/lib/libdfftpack.so
[ 3345s]    /usr/lib/libdream.so
[ 3345s]    /usr/lib/libeutils.so
[ 3345s]    /usr/lib/libfsudace.so
[ 3345s]    /usr/lib/libhopspack.so
[ 3345s]    /usr/lib/libinterfaces.so
[ 3345s]    /usr/lib/libjega.so
[ 3345s]    /usr/lib/libjega_fe.so
[ 3345s]    /usr/lib/liblhs.so
[ 3345s]    /usr/lib/liblhs_mod.so
[ 3345s]    /usr/lib/liblhs_mods.so
[ 3345s]    /usr/lib/libmoga.so
[ 3345s]    /usr/lib/libncsuopt.so
[ 3345s]    /usr/lib/libnidr.so
[ 3345s]    /usr/lib/libnomad.so
[ 3345s]    /usr/lib/liboptpp.so
[ 3345s]    /usr/lib/libpebbl.so
[ 3345s]    /usr/lib/libpecos_src.so
[ 3345s]    /usr/lib/libpecos_util.so
[ 3345s]    /usr/lib/libpsuade.so
[ 3345s]    /usr/lib/libscolib.so
[ 3345s]    /usr/lib/libsoga.so
[ 3345s]    /usr/lib/libsparsegrid.so
[ 3345s]    /usr/lib/libsurfpack.so
[ 3345s]    /usr/lib/libsurfpack_c_interface.so
[ 3345s]    /usr/lib/libsurfpack_fortran.so
[ 3345s]    /usr/lib/libsurfpack_interpreter.so
[ 3345s]    /usr/lib/libtinyxml.so
[ 3345s]    /usr/lib/libutilib.so
[ 3345s]    /usr/lib/libutilities.so