snobu / destreamer

Save Microsoft Stream videos for offline enjoyment.
MIT License
2.37k stars 439 forks source link

Error when trying to download with links in a file #184

Closed RiccardoJR closed 4 years ago

RiccardoJR commented 4 years ago

Hi, after the update 2.1.0 when i try to download videos from a file (".txt"). It gives me this error:

[ERROR] TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined at validateString (internal/validators.js:120:11) at Object.join (path.js:375:7) at D:\destreamer-master\build\src\VideoUtils.js:78:64 at Array.forEach () at Object.createUniquePath (D:\destreamer-master\build\src\VideoUtils.js:75:12) at downloadVideo (D:\destreamer-master\build\src\destreamer.js:101:33) at processTicksAndRejections (internal/process/task_queues.js:97:5)

how can i fix this?

salvmontagna commented 4 years ago

I got the same issue. Besides, when chromium get opened, it gets crashed in the next 10-15 seconds and it returns the following error.

[ERROR] TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined at validateString (internal/validators.js:120:11) at Object.join (path.js:375:7) at D:\destreamer-master\build\src\VideoUtils.js:78:64 at Array.forEach () at Object.createUniquePath (D:\destreamer-master\build\src\VideoUtils.js:75:12) at downloadVideo (D:\destreamer-master\build\src\destreamer.js:101:33) at processTicksAndRejections (internal/process/task_queues.js:97:5)

lukaarma commented 4 years ago

could you try to run with the --verbose/-v flag and paste here your output please? censor as you like usernames or real folder names with fake ones if you like :)

RiccardoJR commented 4 years ago

[VERBOSE] Session and API info API Gateway URL: https://euwe-1.api.microsoftstream.com/api/ API Gateway version: 1.4-private

Parsing input file

[VERBOSE] List of GUIDs and corresponding output directory https://web.microsoftstream.com/video/X => undefined

The error is the same as above

lukaarma commented 4 years ago

would you mind sharing the command you are launching and the input file (censored as you like, I just need to see the structure)? I can't figure out why it's resulting in an undefined directory

RiccardoJR commented 4 years ago

D:\destreamer-master> destreamer.cmd -k -v -f algebra.txt Using ffmpeg version git-2020-07-16-d11cc74 Copyright (c) 2000-2020 the FFmpeg developers

Access token still good for 52 minutes.

[VERBOSE] Session and API info API Gateway URL: https://euwe-1.api.microsoftstream.com/api/ API Gateway version: 1.4-private

Parsing input file

[VERBOSE] List of GUIDs and corresponding output directory https://web.microsoftstream.com/video/=> undefined Edit: Deleted the file for save the link if it could cause some problem

lukaarma commented 4 years ago

Thank you very much, found the bug thanks to you file @RiccardoJR! will push a fix as soon as I can