search

snobu / destreamer

Save Microsoft Stream videos for offline enjoyment.
MIT License
2.37k stars 439 forks source link

Title template #194

Closed lukaarma closed 4 years ago

lukaarma commented 4 years ago

Closes #190

lukaarma commented 4 years ago

@snobu @beppe9000 Here we go

snobu commented 4 years ago

This little bug seems to still hang around:

C:\destreamer [title_template ≡]> .\destreamer.ps1 -i https://msit.microsoftstream.com/video/xxxxxxxxxxxxxxxxxx?list=trending -k --username xxxxxxxxxxxxx@microsoft.com -t ""

[FATAL ERROR] '{date}' is not aviable as a template element
Please check the template elements aviable in the README
snobu commented 4 years ago

@lukaarma Just wanted to say the refresh token capability you introduced (via -k) is going places, i haven't seen something more useful since the introduction of GitHub alone. 5/5 would buy again.

lukaarma commented 4 years ago

This little bug seems to still hang around

Sorry I fixed it quickly the day before leaving for vacation, I'll be back on Sunday. I'll fix it then or I'm sure in 5 Min you could figure it out :D

Thanks for the compliments! Ps: I'm turning notifications off, you can reach me on my personal email if you need

snobu commented 4 years ago

Enjoy vacation. This can wait.

lukaarma commented 4 years ago 
[FATAL ERROR] '{date}' is not aviable as a template element
Please check the template elements aviable in the README

I just realized you didn't pull the updates @snobu :P I'm sure of this because I updated the error message in e355dc1 https://github.com/snobu/destreamer/blob/ea7e563aaca3ec3c3ab9d1e55fec05c4979eae39/src/CommandLineParser.ts#L185-L188

snobu commented 4 years ago

Strage, i think my clone is borked. Keeps saying all changes up to date. Let me do.a fresh clone.

lukaarma commented 4 years ago

any news @snobu?

Edit: as soon as this is merged I have a quick fix that will help with #170 then I'll focus work on my aria2c new branch that's coming along quite well. Keep in mind I have to create 2 projects for Uni between now and mid September so progress will be very slow

snobu commented 4 years ago

Merged. Thank you for your continued support and contributions, @lukaarma!

beppe9000 commented 4 years ago

great!