search

snobu / destreamer

Save Microsoft Stream videos for offline enjoyment.
MIT License
2.36k stars 440 forks source link

Lorem ipsum #264

Closed ghost closed 3 years ago

snobu commented 3 years ago

Puppeteer talks DevTools protocol which is Chromium only. You'll want Microsoft's Playwright to go cross browser,, including Firefox. Should be an easy change in destreamer.ts. Maybe, not sure, everything looks trivial if you don't personally need it :)

https://github.com/microsoft/playwright

tajnymag commented 3 years ago

@snobu Puppeteer supports Firefox natively since version 3.0. (Source)

The problem @alds-02agem experiences might be due to a different set of flags needed to be passed to the firefox binary.

I haven't made it to work myself, but it should theroretically work with the correct puppeteer config.

snobu commented 3 years ago

If you look in package.json we are using puppeteer 2.1.1. Try to upgrade to 3.x then, hopefully no other changes are necessary.

tajnymag commented 3 years ago

The aria2c_forRealNow branch currently uses puppeteer 5.3.0. That might also be an option.

lukaarma commented 3 years ago

I used Firefox while testing my branch and it did work, so @alds-02agem you could try the new branch or update puppeteer in the master branch