search

snobu / destreamer

Save Microsoft Stream videos for offline enjoyment.
MIT License
2.36k stars 441 forks source link

*BUG* --cc doesn't work when --format " " is specified #299

Open luke-who opened 3 years ago

luke-who commented 3 years ago

Hi just found that the --cc flag doesn't work if --format " " is specified other than using the default "mkv", which doesn't need to be specified at all. It seems --cc only works when there's no --format specified could you pls fix that? Cheers!

lukaarma commented 3 years ago

Oh yeah, probably ASS can't be placed in any container.. do you have any specific example?

luke-who commented 3 years ago

yes for example ./destreamer.sh --cc --format "mp4" -i https://web.microsoftstream.com/video/xxxxxxxxxxxxxxxx or ./destreamer.sh --cc --format "mov" -i https://web.microsoftstream.com/video/xxxxxxxxxxxxxxxx will only download the video but won't generate any caption

however
./destreamer.sh --cc --format "mkv" -i https://web.microsoftstream.com/video/xxxxxxxxxxxxxxxx will do both and works fine as a result, although downloading video is fine, it seems it won't work on generating captions(--cc) when you specify any formats other than "mkv" Hope that helps :-)

lukaarma commented 3 years ago

The issue is what I stated above, should be a quick fix @snobu. Here is what i found:

./destreamer.sh --cc --format "mp4" -i https://web.microsoftstream.com/video/xxxxxxxxxxxxxxxx

Need to add -c:s mov_text when mp4 is selected

./destreamer.sh --cc --format "mov" -i https://web.microsoftstream.com/video/xxxxxxxxxxxxxxxx

Same as above because if i remember right QTFF it's just a fancy mp4