search

snobu / destreamer

Save Microsoft Stream videos for offline enjoyment.
MIT License
2.37k stars 439 forks source link

/group download very slow to start #310

Open snobu opened 3 years ago

snobu commented 3 years ago

When trying to download a group

./destreamer.sh -i https://msit.microsoftstream.com/group/GROUP-GUID

Things become very very slow right here 

Parsing video/group urls
Fetching videos info...

Which is to be expected since groups usually have an Elon Musk's net worth in Japanese Yen number of videos.

We should either put a cap on it or allow people to pass -limit and -offset parameters (better naming welcome) so the API spraying is a bit more controlled.

lukaarma commented 3 years ago

We could create an hidden "archive" file that keep track of group UUIDs and to which index the last video arrived

snobu commented 3 years ago

Destremer shall remain stateless. Well, except login cookies.. necessary evil. Group downloads are rare... i hope, so let's put in minimal effort... for maximum satisfaction :)

lukaarma commented 3 years ago

We could use the async nature of JS and request them slowly in the background while downloading the others? Or we could do what you suggested, after the end of February, when I'm done with the exams I could take a look

lukaarma commented 3 years ago

@snobu maybe this could be solved implementing it as #333 suggests, adding a "afterDate" argument.