search

snobu / destreamer

Save Microsoft Stream videos for offline enjoyment.
MIT License
2.36k stars 442 forks source link

Template elements are no more mandatory in final name. #345

Closed goldmont closed 3 years ago

goldmont commented 3 years ago

Closed #344

goldmont commented 3 years ago

Ok man, let me do it

goldmont commented 3 years ago

I'm done @lukaarma

snobu commented 3 years ago

@lukaarma when this meets your quality bar just merge it, don't wait for me.

lukaarma commented 3 years ago

@snobu there is a minor linting error, should I revert it or its not worth for such a small fix?

goldmont commented 3 years ago

@lukaarma Thank you, keep up the good work.

goldmont commented 3 years ago

@snobu there is a minor linting error, should I revert it or its not worth for such a small fix?

Where?

lukaarma commented 3 years ago 
destreamer/destreamer/src/CommandLineParser.ts
Error:   177:9  error  'finalTemplate' is never reassigned. Use 'const' instead  prefer-const
goldmont commented 3 years ago

I'm gonna fix it right now.