snobu / destreamer

Save Microsoft Stream videos for offline enjoyment.
MIT License
2.36k stars 442 forks source link

skipping of existing videos not working in Sharepoint branch #415

Open lukaarma opened 2 years ago

lukaarma commented 2 years ago

Hello everybody, just wanted to point out a minor issue related to the skipping of existing videos

On this line, aside from the unused call to createUniquePath , a check for an eventual existing file should be added

    for (const [index, video] of videos.entries()) {
     if (argv.skip && fs.existsSync(video.outPath)) {
            logger.info(`File already exists, skipping: ${video.outPath} \n`);
            continue;
        }
...

Originally posted by @darderik in https://github.com/snobu/destreamer/issues/380#issuecomment-954107385

ghost commented 2 years ago

Same issue, if download 2 times the same file ffmpeg crashes and deletes the file already downloaded