search

snobu / destreamer

Save Microsoft Stream videos for offline enjoyment.
MIT License
2.36k stars 442 forks source link

2 problems with the description of the "-t" key #420

Open atnt0 opened 2 years ago

atnt0 commented 2 years ago

OS: Windows 10 Pro 1909

Launch command used: destreamer.cmd -f C:\Users\user\Desktop\links.txt -v -x -k -t '{publishDate} - {publishTime} - {duration} - {title}' --format mp4 -o Z:\FILES

Verbose log ``` PASTE VERBOSE LOG HERE ```

Hello! This is my first suggestion for improving anyone's repository, please do not scold for incorrect design. There are 2 errors in the description of the "-t" switch:

  1. The examples describe the use of "'" (that is, a single quote), when you need to use "" "(double quotes) or at least mention it in the description, since otherwise the file naming will be incorrect.
  2. In the descriptions of the "{duration}" and "{publishTime}" templates, the time format is specified using the ":" character (that is, a colon), whereas in the Windows operating system this character is not allowed in file names. As a result, the symbol is replaced with "." (i.e. point). Please correct the description or add the ability to independently customize the date and time format in file names.