snoe / deedum

A cross platform Gemini browser
GNU General Public License v3.0
128 stars 13 forks source link

Data loss on double screen rotation #62

Open davirec opened 2 years ago

davirec commented 2 years ago

In the double screen rotation test to detect data loss, an application failure was identified: the pop-up menu disappeared after double rotation.

A data loss problem occurs when data is accidentally deleted or state variables are accidentally assigned with default or initial values. This issue is related to the activity's lifecycle (1). When a screen rotation occurs, the activity is destroyed and resumed. Data loss will happen if the developer does not save the variables before the destruction and restore them after creation. To avoid this, the developers have to implement both the logic necessary to save the activity state in the onSaveInstanceState() callback method and the logic to resume its state in the onRestoreInstanceState() callback method. Another way to avoid data loss problems is to use the view model, designed to store and manage UI-related data in a lifecycle-conscious way (2).

Before and after double screen rotation

Note:

  1. https://developer.android.com/guide/components/activities/activity-lifecycle
  2. https://developer.android.com/topic/libraries/architecture/viewmodel
snoe commented 2 years ago

@davirec unless this is causing pain for more people, I probably won't get to this. PR welcome though.