search

snok / asgi-correlation-id

Request ID propagation for ASGI apps
MIT License
414 stars 32 forks source link

#022 Convert headers to raw headers to handle the case of duplicate header… #25

Closed lakshaythareja closed 2 years ago

lakshaythareja commented 2 years ago

… keys

codecov[bot] commented 2 years ago

Codecov Report

Merging #25 (21bb54d) into main (c8febfd) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          276       291   +15     
=========================================
+ Hits           276       291   +15
Impacted Files Coverage Δ
asgi_correlation_id/middleware.py 100.00% <100.00%> (ø)
tests/test_middleware.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8febfd...21bb54d. Read the comment docs.

JonasKs commented 2 years ago

Hi, thank you!😊 Could you add a test for this? So we know it won’t happen again.

sondrelg commented 2 years ago

Yes thanks @lakshaythareja 👏 If you add a test I'm happy to merge this.

Btw, to pass linting you can do 

pip install pre-commit
pre-commit install
pre-commit run --all-files
sondrelg commented 2 years ago

Thanks @lakshaythareja