search

snok / asgi-correlation-id

Request ID propagation for ASGI apps
MIT License
414 stars 32 forks source link

Allow string-based configuration for logging filters #33

Closed faph closed 2 years ago

faph commented 2 years ago

See #32

faph commented 2 years ago

@sondrelg Let me know if this makes sense

codecov[bot] commented 2 years ago

Codecov Report

Merging #33 (b612e78) into main (791ea1c) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          284       314   +30     
=========================================
+ Hits           284       314   +30
Impacted Files Coverage Δ
tests/conftest.py 100.00% <ø> (ø)
asgi_correlation_id/__init__.py 100.00% <100.00%> (ø)
asgi_correlation_id/log_filters.py 100.00% <100.00%> (ø)
tests/test_log_filter.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 791ea1c...b612e78. Read the comment docs.

sondrelg commented 2 years ago

Looks great @faph 👍 I'll deprecate and release v2 today or sometime this weekend!