search

snok / asgi-correlation-id

Request ID propagation for ASGI apps
MIT License
413 stars 32 forks source link

docs: Add docs for SAQ #47

Closed sondrelg closed 2 years ago

sondrelg commented 2 years ago

Haven't had the opportunity to really test this. Do you know if context vars will restrict state to within individual asyncio tasks @JonasKs? If not, perhaps we would need to create a separate context variable where we register CIDs by task ID instead.

codecov[bot] commented 2 years ago

Codecov Report

Merging #47 (d073867) into main (d859363) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head d073867 differs from pull request most recent head 363b431. Consider uploading reports for the commit 363b431 to get more accurate results

@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          353       353           
=========================================
  Hits           353       353
Impacted Files Coverage Δ
asgi_correlation_id/log_filters.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sondrelg commented 2 years ago

Seems to be the case. Will merge this for now and update if needed in the coming days.