snok / django-auth-adfs

A Django authentication backend for Microsoft ADFS and AzureAD

http://django-auth-adfs.readthedocs.io/

BSD 2-Clause "Simplified" License

272 stars 99 forks source link

WIP: Multiple idps #201

Open peterfarrell opened 2 years ago

peterfarrell commented 2 years ago

WIP for #117

codecov[bot] commented 2 years ago

Codecov Report

Merging #201 (c45c685) into master (e9808eb) will increase coverage by 0.2%. The diff coverage is 79.5%.

@@           Coverage Diff            @@
##           master    #201     +/-   ##
========================================
+ Coverage    85.9%   86.1%   +0.2%     
========================================
  Files          11      11             
  Lines         497     505      +8     
========================================
+ Hits          427     435      +8     
  Misses         70      70

Impacted Files	Coverage Δ
django_auth_adfs/config.py	`87.8% <79.5%> (+0.4%)`	:arrow_up:

sondrelg commented 2 years ago

Hi @peterfarrell. What's the status for this PR? 🙂

peterfarrell commented 2 years ago

@sondrelg Still a WIP and blocked by: https://github.com/jpadilla/pyjwt/issues/433

JonasKs commented 2 years ago

Did you see my comment in #117 @peterfarrell ?

peterfarrell commented 2 years ago

@JonasKs Yes, I did. I don't have the bandwidth to retro-fit anything more than a static list of issuers right now. I'm not familiar with Python-Jose. Does it have the same API as pyJWT?

JonasKs commented 2 years ago

Pretty much, yeah. It is a cleaner implementation, imo.