search

snok / django-auth-adfs

A Django authentication backend for Microsoft ADFS and AzureAD
http://django-auth-adfs.readthedocs.io/
BSD 2-Clause "Simplified" License
270 stars 98 forks source link

re #270 - Added middleware to refresh access tokens #278

Open daggaz opened 1 year ago

daggaz commented 1 year ago

This PR addresses #270

codecov[bot] commented 1 year ago

Codecov Report

Merging #278 (9abbcbd) into master (80adc32) will increase coverage by 0.7%. The diff coverage is 95.4%.

@@           Coverage Diff            @@
##           master    #278     +/-   ##
========================================
+ Coverage    86.3%   87.1%   +0.7%     
========================================
  Files          11      11             
  Lines         549     590     +41     
========================================
+ Hits          474     514     +40     
- Misses         75      76      +1
Impacted Files Coverage Δ
django_auth_adfs/backend.py 87.1% <93.3%> (+0.7%) :arrow_up:
django_auth_adfs/config.py 88.0% <100.0%> (+<0.1%) :arrow_up:
django_auth_adfs/middleware.py 94.2% <100.0%> (+3.3%) :arrow_up:
django_auth_adfs/views.py 87.2% <0.0%> (+2.1%) :arrow_up:
JonasKs commented 1 year ago

I'll try to review ASAP, but I'm pretty busy these days. If we're afraid of breaking, we'll have to major bump - I don't mind that 😊

JonasKs commented 1 year ago

Thanks for the good PR! And for the good review, @tim-schilling 😊 I'd love to get this merged this or next week.