search

snok / django-auth-adfs

A Django authentication backend for Microsoft ADFS and AzureAD
http://django-auth-adfs.readthedocs.io/
BSD 2-Clause "Simplified" License
272 stars 99 forks source link

fix: do not hardcode scopes for azure AD v2 #279

Closed JonasKs closed 1 year ago

JonasKs commented 1 year ago

No idea how I didn't see this when I approved.

Added new setting for SCOPES which can be used with v2 tokens.

JonasKs commented 1 year ago

The entire AzureAD tutorial does not work. I'll have to rewrite it entirely. Fixing bugs as I go.

codecov[bot] commented 1 year ago

Codecov Report

Merging #279 (77aedee) into master (80adc32) will decrease coverage by 0.2%. The diff coverage is 77.7%.

:exclamation: Current head 77aedee differs from pull request most recent head 1f2dc70. Consider uploading reports for the commit 1f2dc70 to get more accurate results

@@           Coverage Diff            @@
##           master    #279     +/-   ##
========================================
- Coverage    86.3%   86.1%   -0.2%     
========================================
  Files          11      11             
  Lines         549     556      +7     
========================================
+ Hits          474     479      +5     
- Misses         75      77      +2
Impacted Files Coverage Δ
django_auth_adfs/config.py 87.5% <75.0%> (-0.5%) :arrow_down:
django_auth_adfs/__init__.py 100.0% <100.0%> (ø)