snok / django-auth-adfs

A Django authentication backend for Microsoft ADFS and AzureAD
http://django-auth-adfs.readthedocs.io/
BSD 2-Clause "Simplified" License
270 stars 101 forks source link

CodeCov token may need to be reuploaded #349

Open tim-schilling opened 3 weeks ago

tim-schilling commented 3 weeks ago

As per https://github.com/snok/django-auth-adfs/actions/runs/11106517309/job/30855027879#step:8:40

Run codecov/codecov-action@v2
==> linux OS detected
https://uploader.codecov.io/latest/linux/codecov.SHA256SUM
==> SHASUM file signed by key id 806bb28aed779869
==> Uploader SHASUM verified (b37359013b48fbc3b0790d59fc474a52a260fb96e28e1b2c2ae001dc9b9cc996  codecov)
==> Running version latest
==> Running version v0.8.0
/home/runner/work/_actions/codecov/codecov-action/v2/dist/codecov -n  -Q github-action-2.1.0 -Z -f ./coverage.xml
[2024-09-30T12:54:20.870Z] ['info'] 
     _____          _
    / ____|        | |
   | |     ___   __| | ___  ___ _____   __
   | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
   | |___| (_) | (_| |  __/ (_| (_) \ V /
    \_____\___/ \__,_|\___|\___\___/ \_/

  Codecov report uploader 0.8.0
[2024-09-30T12:54:20.878Z] ['info'] => Project root located at: /home/runner/work/django-auth-adfs/django-auth-adfs
[2024-09-30T12:54:20.881Z] ['info'] -> No token specified or token is empty
[2024-09-30T12:54:20.888Z] ['info'] Searching for coverage files...
[2024-09-30T12:54:21.101Z] ['info'] => Found 1 possible coverage files:
  ./coverage.xml
[2024-09-30T12:54:21.101Z] ['info'] Processing ./coverage.xml...
[2024-09-30T12:54:21.104Z] ['info'] Detected GitHub Actions as the CI provider.
[2024-09-30T12:54:21.265Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-2.1.0-uploader-0.8.0&token=*******&branch=master&build=11106517309&build_url=https%3A%2F%2Fgithub.com%2Fsnok%2Fdjango-auth-adfs%2Factions%2Fruns%2F11106517309%2Fjob%2F30855027879&commit=5ea3c87036461e727132efbdfba6d30d17a3687f&job=coverage&pr=&service=github-actions&slug=snok%2Fdjango-auth-adfs&name=&tag=&flags=&parent=
[2024-09-30T12:54:21.558Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 3093s."}

Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v2/dist/codecov' failed with exit code 255

Upvote & Fund

Fund with Polar

sajoku commented 6 days ago

Seems to be a GitHub (and opensource) wide issue; https://github.com/codecov/feedback/issues/301

There is a workaround https://github.com/codecov/feedback/issues/301#issuecomment-2009355183 . In short it uploads the coverage report to GitHub itself (as an artefact) and will upload to codecov when it can.

JonasKs commented 6 days ago

Thanks @tim-schilling and @sajoku!

I don't really know if we want to continue with codecov upload on PRs after this? I think, without uploads, we'll just be able to see the coverage % in our pipelines, which is probably enough.

Or just wait for Codecov to fix it, the proposed workaround seems a bit hacky to me.

What I'm suggesting is basically setting this to false:

-        fail_ci_if_error: true
+        fail_ci_if_error: false
tim-schilling commented 5 days ago

I'm fine with that change