search

snok / install-poetry

Github action for installing and configuring Poetry
MIT License
572 stars 53 forks source link

fix: solve permission denied when running with act #117

Closed pietrobolcato closed 1 year ago

pietrobolcato commented 1 year ago

When testing the action locally using act, it returns

/var/run/act/workflow/1-composite-0.sh: line 2: /var/run/act/actions/snok-install-poetry@v1.3.3/main.sh: Permission denied

This commit fixes the issue by setting the execution permission on the main installer script

JonasKs commented 1 year ago

I'm not sure why this change would be needed in act, when it is not required in GitHub actions? To my knowledge act uses the same docker images, so whether the file has execution rights or not, should result in the same in both environments?

To me this sounds like an act bug.

sondrelg commented 1 year ago

Thanks for the PR :slightly_smiling_face:

If the script isn't executable, would it be enough to chmod it locally and commit it? I can test with act after work today.

Looks like we also have some existing tests failing, but that seems unrelated.

JonasKs commented 1 year ago

Good suggestion! Seems like it's possible

pietrobolcato commented 1 year ago

Great find! Let us know once you tried it out, thank you!

JonasKs commented 1 year ago

You're welcome to try it out if you'd like😊

deronnax commented 1 year ago

I think it can be closed now, can't it? Anyway if it works on Github Actions and not in act, it's totally a bug in act, and that need to be fixed in act.

sondrelg commented 1 year ago

Yep think you're right