search

snok / install-poetry

Github action for installing and configuring Poetry
MIT License
572 stars 53 forks source link

Remove `curl` dependency #153

Closed ivanychev closed 1 month ago

ivanychev commented 1 month ago

Thanks for the amazing GitHub Action!

This PR removes curl usage from the script and replaces it with python3. Many hosted GitHub Action runners don't have curl by default, so they are required to install it before using this action. This PR ensures that the installation of curl is not needed.

sondrelg commented 1 month ago

Cool. I agree, cutting dependencies is good, but would you mind showing me documentation that python3 always needs to be present in self-hosted runners? Otherwise, aren't we just substituting one dependency for another?

ivanychev commented 1 month ago

Hey @sondrelg! The script already relies on Python 3 to install poetry (search for python3 in the file). The script uses the “official” way of installing poetry: (https://python-poetry.org/docs/#installing-with-the-official-installer) — it downloads Python script and executes it.

sondrelg commented 1 month ago

Hehe yeah good point. I'll try to get this reviewed properly this week 👍

sondrelg commented 1 month ago

Thanks @ivanychev. This looks good!