snollygolly / sourceio-automation

:video_game: A bot to automatically play s0urce.io for you
MIT License
28 stars 27 forks source link

Random target selection and some corrections #25

Closed abxu closed 7 years ago

abxu commented 7 years ago
snollygolly commented 7 years ago

I have concerns about the way we're doing player targeting in this PR. At low levels, randomizing the target to attack is totally fine, because it doesn't matter. As we get up in the ranks, we start to need to target a specific player over and over without randomization (usually because one player is RICH).

In addition to that, #26 was submitted last night and touches on all of these issues. I've requested changes in that PR, so I'll leave this one open for now (in case the other contributor doesn't fix the requested changes).

Thanks for your contribution!

abxu commented 7 years ago

Except that at high level, there are only bots that do the same thing and there is a high probability of not winning the hack when many players are on the same port. I don't think that the money is important, we earn enough money, when we climb the rankings, to secure the firewalls.

snollygolly commented 7 years ago

That's a fair point. I just know that when I used to use this bot, that was my biggest complaint. Once I got high enough, it wouldn't stay targeted on the person I wanted. You're right though, money isn't super important in the late game really.

menitol commented 7 years ago

Great! Thanks for fixing this bug. Just one line lol. Imo, the miners are useless for a bot. I disable the miner loop now because I lose more money on a hack and I pay more to hack.

menitol commented 7 years ago

Last week, there was a bot called '<:3 )~~~' when I attacked him my 3 ports were hacked instantly. Can you add this feature? It would be really cool.

snollygolly commented 7 years ago

@menitol can you put your feature request into an issue? The PR isn't the right place to discuss it. Thanks!

menitol commented 7 years ago

Ok sorry