Perfect - Githubissues

snollygolly / sourceio-automation

:video_game: A bot to automatically play s0urce.io for you

MIT License

28 stars 27 forks source link

Perfect #3

Closed bozoweed closed 7 years ago

bozoweed commented 7 years ago

hi have finish to debug you code it's now work perfect ( for the line 45 in main.js they have my git forget to change it sorry )

bozoweed commented 7 years ago

but can i ask you something ? why the bot upgrade the firewall only after finish the current hack ?

snollygolly commented 7 years ago

I'm only updating after the current hack because that feature is still new and I was testing it. I intend to run it on a timer like the other loops eventually.

Also, I requested that you take your word length fix (line 270) and put it into a new PR. I'll gladly merge it, that's an oversight on my part (thanks for the catch). I'm not going to be merging the rest of the changes though, they seem to be matters of opinion rather than bugs or deficiencies.

bozoweed commented 7 years ago

it's not opinion it'sw the true your code doesn't work sorry if you don't want seen the only one true make some test if you are a real dev make a log with world and worldlink and you will seen how you must code it bye

snollygolly commented 7 years ago

Your PR is kind of a mess man.

You changed all the DB urls to have www. in front of them, and I can't see any reason for it. Both versions work for me. I haven't seen any screenshots or anything indicating they don't.
You changed the default hacking message because you didn't like it.
You changed the DB URL to point to YOUR repository instead of mine.

You keep saying I need to try your version because I'll see that it's better, but I don't have a problem with the current version. It works for me, and it took me to top 5 yesterday.

I'm happy to accept pull requests that fix bugs (see the other two PRs I accepted without any debate already). I won't be merging messy PR's that consist mostly of opinion issues and then close by calling me "not a real dev". No thanks.

bozoweed commented 7 years ago

what is you web browser ? what is your system ? me firefox me windows 7 and bugged exemple say text no found and go on orc to found it and return status' where is status uses where is user client1 where is client and never found from db.json but whit my update i never bug again may be we need to speak about that in vocal chat on in teamviwers on my pc ( you connect on my pc )

bozoweed commented 7 years ago

and i have never say you are not a dev i have say "if your a real dev" so if it is you are eles you are not don't change what i say ( i dev from 6 years ago i get level master from french so don't be scare to learn with me bro ) master is more than 5 years of studie in french university