snoonetIRC / CloudBot

CloudBot - The simple, fast, expandable, open-source Python IRC Bot!
GNU General Public License v3.0
67 stars 52 forks source link

Duckhunt should not be active in query windows #1

Closed langerhans closed 9 years ago

langerhans commented 9 years ago

Sorry, I'd totally put in a PR, but I don't know CloudBot well enough. It should have that in the hook params somewhere, no?
Noticed that you can .starthunt in a query window and the bot will happily spawn ducks. Since that would probably count towards the global stats, it should not be possible. Might want to clean the database too if it was abused already.

[18:02:31]<langerhans> .starthunt
[18:02:32]<gonzobot> Ducks have been spotted nearby. See how many you can shoot or save. use .bang to shoot or .befriend to save them.
[18:21:59]<gonzobot> ・゜ ​ ゜・。。・゜゜\_O<​ FL​AP FLAP!
[18:22:03]<langerhans> .bef
[18:22:03]<gonzobot> langerhans you befriended a duck in 4.266 seconds! You have made friends with 1 duck in langerhans.
[18:22:15]<langerhans> .friends
[18:22:15]<gonzobot> Duck friend scores in langerhans: l​angerhans: 1
[18:23:01]<langerhans> .stophunt
[18:23:01]<gonzobot> the game has been stopped.
edwardslabs commented 9 years ago

Thanks! - this should fix it https://github.com/snoonetIRC/CloudBot/commit/a51f1d393d9d32dc860398e4fc25b3a4a1793e8a

langerhans commented 9 years ago

:+1: I think so, Snoonet doesn't allow other channel prefixes afaik