search

snoonetIRC / CloudBot

CloudBot - The simple, fast, expandable, open-source Python IRC Bot!
GNU General Public License v3.0
67 stars 52 forks source link

Clean up Hook attribute init #605

Closed linuxdaemon closed 5 years ago

linuxdaemon commented 5 years ago

Move all attribute assignments to after the super class init call. This ensures that the basic class is initialized before extending it and prevents a super class overriding a subclass's fields.

codecov[bot] commented 5 years ago

Codecov Report

Merging #605 into gonzobot will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           gonzobot     #605      +/-   ##
============================================
+ Coverage     54.52%   54.54%   +0.01%     
============================================
  Files           232      232              
  Lines         14200    14205       +5     
============================================
+ Hits           7743     7748       +5     
  Misses         6457     6457
Impacted Files Coverage Δ
cloudbot/plugin_hooks.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c83b179...debf60c. Read the comment docs.