Closed lacksfish closed 2 years ago
I've also replaced all external CDN links pointing to CSS or JavaScript files with local files installed through NPM. This helps when running this project in an offline environment.
For upload.html
a different angular version was used. 1.1.1
instead of 1.3.9
. I'm assuming this is on purpose and I've included angular1.1.1.min.js
in the public/static
folder. I did not manage to npm install angular 1.1.1 as it led to errors while installing.
Nice PR, your changes looks good, i ll merge
Update node and python, add image name in docker-compose, package.json update
Summary
For node v13 I did not manage to install the dependencies (I think node-gyp failed, I forgot) Next i changed the node docker image to v16, which resulted in further issues because some node dependency needed python above 3.6 for the install. Unfortunately, only python 3.5 was available on the previous docker image
node:13.14.0-stretch-slim
. Instead of manually building/installing python 3.7 in the Dockerfile, I settled on the docker image nikolaik/python-nodejs:python3.7-nodejs16-slimFurther,
package.json
dependency "express-fileupload" specific version can alternatively also be fetched from NPM, like every other dependency in the project already is. Not depending on git/github for this one dependency has the benefit of solving potential install issues related to how git pulls the data (SSH, which might not be accessible on all installs)Other changes:
docker-compose.yml
: suggestion issnoopysecurity/dvws-node:latest
I'm open to discussing which changes are reasonable, I'm basically just sharing and summarizing what I did to setup the project ✌️