search

snoplus / orca

Git repository tracking the main Orca svn for SNO+ development
2 stars 13 forks source link

Fix TUBii orphans #508

Closed EdLeming closed 6 years ago

EdLeming commented 6 years ago

This PR removes the problem runAboutToStart function from the TUBii model and moves the registration of notification observers to initWithCoder.

A single line is also added to the keepAliveFunction so the ELLIE gui properly updates when the keepAlive is no longer running. The time between pulses is also increase to 5s in order to avoid 'flooding' the TUBii server with more request then are required. I checked with @icoulter and the server itself expects a ping every 30s, so this is still well within tolerance.

@tlatorre-uchicago, if it's possible it might be a good idea to test this on the detector later when you're deploying the new servers.

EdLeming commented 6 years ago

Good point. It worked on the teststand, but there's gotta be a race going on there. I've moved to post client allocation.

boardhead commented 6 years ago

Merged