search

snoplus / orca

Git repository tracking the main Orca svn for SNO+ development
2 stars 13 forks source link

Prevent tubii run start exception from bubbling up #514

Closed marzece closed 6 years ago

marzece commented 6 years ago

When starting a run tubii's runAboutToStart function gets called and if it raises an uncaught exception the run will be prevented from starting. I think we don't in general want this to be the case so this commit just catches and warns about any exceptions that occur instead of letting them stop the run from starting. Fixes #505

boardhead commented 6 years ago

I think this PR is not applicable once #508 has been applied.

ecaden commented 6 years ago

Hi Phil,

When will it be applied?

Thanks, Erica

-- Erica Caden, Ph.D. SNOLAB Research Scientist SNO+ Detector Manager ecaden@snolab.ca +1.705.692.7000 x2253

On Jul 16, 2018, at 8:33 AM, Phil Harvey notifications@github.com wrote:

I think this PR is not applicable once PR#508 has been applied.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/snoplus/orca/pull/514#issuecomment-405232432, or mute the thread https://github.com/notifications/unsubscribe-auth/AEdIUe2sTUZO50osWeIMJWMPRbJTTKaCks5uHIgSgaJpZM4VQAok.

tannerbk commented 6 years ago

@boardhead we cannot run the detector currently, so this or #508 should go on in ASAP.

boardhead commented 6 years ago

Should not be necessary since #508 is now applied