snoplus / snoing

New snocave installation method for SNO+. Sno packages fall from the web (sky), i.e. snoing.
Other
5 stars 27 forks source link

errors with curl install #147

Open jlidgard opened 6 years ago

jlidgard commented 6 years ago

see line 41 curl.py

"self.get_install_path()" should be "self._system.get_install_path()"

also, "_download" isn't called. (changing this to "download" worked for me.. something going on..)

jlidgard commented 6 years ago

this error causes curl to be reported as 'installed' or 'downloaded' but is not actually installed or downloaded (the default flag is true?)

parnmatt commented 6 years ago

This will take me a while to be sure what's gone wrong; this part of the code was written many years ago. The whole of snoing could do with a rewrite; we just don't have time.

On quick inspection, that part of the code should only be executed if libcurl is not installed. If there is an error in the code here, it would make sense that it wouldn't have been picked out for years because libcurl is installed on almost every system by default. What OS are you running this on?