snoplus / tellie

The timing ELLIE LED calibration system
0 stars 11 forks source link

Control box testing #26

Closed Mark--S closed 7 years ago

Mark--S commented 7 years ago

This PR fixes the Issue we were seeing with being unable to read the PINs on the upper boxes. The character commands b and p (To read the PINS in slave mode) for the PIC chip were the wrong way around in the code. Also the check on the channel number would always perform the upper box PIN reading as line 402 in tellie_server was comparing a list and a number. So whatever channel we were pulsing only the lower box PIN readings would be taken.

I've also changed the parsing of the PIN readings from the buffer. If a PIN reading of zero is returned the RMS is returned in the format .000000 (no leading 0) the regex expression seemed to be having trouble with this.