search

snoplus / tellie

The timing ELLIE LED calibration system
0 stars 11 forks source link

Updated pause time #35

Closed Mark--S closed 7 years ago

EdLeming commented 7 years ago

Hey Mark. What;s this for?

Mark--S commented 7 years ago

This is the fix to stop the crashing yesterday. The server was seeing unexpected buffer output as there wasn't enough delay in obtaining the PIN readings at the end of a subrun.

The changes in the stop function were made before as I think the code would throw an unexpected buffer content if we didn't read it before sending the other commands. I think we forgot to merge them into master.

mnirkko commented 7 years ago

Beware that in tellie.cfg, the parameter "short_pause" was changed from 0.1 to 0.3 - this parameter is used very often, so the code will run a lot slower... do we want this?

/Edit: The best workaround would probably be to change the sleep() command before the buffer readout to medium_pause in only that instance. Then you will wait for 1.0 second, but won't delay the rest of the code. (Thus short_pause can still be set to 0.1.)

Alternatively, we can just add a new parameter buffer_pause = 0.3 if you think that is more appropriate.

mnirkko commented 7 years ago

This can be closed now, since the changes here were implemented in #37.