search

snoplus / tellie

The timing ELLIE LED calibration system
0 stars 11 forks source link

Bug fix for issues seen UG on Feb 8th, 2018 #44

Closed mnirkko closed 6 years ago

mnirkko commented 6 years ago

Add new functions to call in case of PIN read timeout, to be called in ORCA. This should prevent problems occuring when a previous subrun did not receive the correct number of triggers in Slave mode. Instead, the PIN readings can be extracted and a "soft stop" command is sent. This stops TELLIE firing and clears the buffer, but does not clear all the fibre settings (channel, pulse number etc.) - that way, a new subrun can be started quickly. This fixes a symptom only, it is not a solution for missing EXTA triggers!

EdLeming commented 6 years ago

Thanks Martti. I guess you've tested this on the teststand? I'm probably missing it, but I don't see where read_pin_sequence_timeout() gets called?

mnirkko commented 6 years ago

It doesn't! :D This is a new function that needs to be called in ORCA (see above). Will write some more instructions when I have a moment, but it was a late night yesterday...

EdLeming commented 6 years ago

Ahhh, I see. OK. Thanks! I'll put in the relevant ORCA PR next week. If I don't send you conformation that I've done so please nudge me next week.

EdLeming commented 6 years ago

I just put up the PR for this. See below:

https://github.com/snoplus/orca/pull/489

mnirkko commented 6 years ago

Looks good. If we can pull this through, I can update snodrop to the snoplus/master branch on Monday, when I'm UG testing TELLIE/TUBii.