new couchdb tools in tools, new check tools in pca_tools

snoplus / tellie

The timing ELLIE LED calibration system

0 stars 11 forks source link

Closed MRiganSUSX closed 4 years ago

mnirkko commented 4 years ago

A few questions here:

Aren't the get_channel and update_channel scripts already contained in PR #47 ?
Do we want PCA run lists to be contained in the Git repo? I have no problem with that, but please use YYYY-MM format (not single digit months). Other than that, looks good!

MRiganSUSX commented 4 years ago

Added most of the requested changes, left comments for the rest. Thanks for your time!

mnirkko commented 4 years ago

There are two ODS files and I'm not sure of their purpose.

pca_tools/tellie_tables.ods just contains one line that points to a specific path on one of @MRiganSUSX computers.
pca_tools/TELLIE_water_setpoints.ods is a full copy of the Google spreadsheet (I assume), is this intended as backup?

MRiganSUSX commented 4 years ago

Thanks for the comments and the review.

will remove tellie_tables.ods from working tree
the water_setpoints.ods is indeed a backup. It's important enough file that should be available at more than 1 location I think.