search

snoplusuk / echidna

MIT License
4 stars 12 forks source link

zradial3 extractor #112

Closed jwaterfield closed 7 years ago

jwaterfield commented 8 years ago

An extractor for (z/|z|)*(r/r_av)^3. Similar to radial3 but splits the detector into two hemispheres.

Also updated some wrong doc

ashleyrback commented 8 years ago

Quite a lot of warnings/errors building docs. I think it's mainly from a few places where you've put :math:``(z/\lvert z \rvert)(radius/outer\_radius)^3`` instead of:math:`(z/\lvert z \rvert)(radius/outer_radius)^3``.

/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC:3: ERROR: Unexpected indentation.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC:10: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC:11: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC:17: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC.get_value_ntuple:3: ERROR: Unexpected indentation.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC.get_value_ntuple:1: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC.get_value_ntuple:9: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC.get_value_ntuple:10: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC.get_value_root:3: ERROR: Unexpected indentation.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC.get_value_root:1: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC.get_value_root:9: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractMC.get_value_root:10: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco:3: ERROR: Unexpected indentation.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco:1: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco:10: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco:11: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco:14: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco:20: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco.get_value_ntuple:3: ERROR: Unexpected indentation.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco.get_value_ntuple:1: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco.get_value_ntuple:10: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco.get_value_ntuple:11: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco.get_value_root:3: ERROR: Unexpected indentation.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco.get_value_root:1: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco.get_value_root:10: WARNING: Inline literal start-string without end-string.
/home/ashley/snoplus/software/echidna/echidna-pr/echidna/core/dsextract.py:docstring of echidna.core.dsextract.ZRadial3ExtractReco.get_value_root:11: WARNING: Block quote ends without a blank line; unexpected unindent.
ashleyrback commented 8 years ago

Other than doc warnings/errors, looks good to merge.