snoplusuk / echidna

MIT License
4 stars 12 forks source link

Fixes stats bug in `Summary`. #135

Closed ashleyrback closed 8 years ago

ashleyrback commented 8 years ago

Summary class was often not updating the values for min_per_bin and using a previous definition. This often resulted in subtracting the wrong per_bin values when calculating delta-test-statistic and eneded up with negative values for the test statistic. This fixes the problem by always redefining min_per_bin.

ashleyrback commented 8 years ago

I've already found a small bug in the Limit class, @EdLeming or @mjmottram would you mind quickly reviewing?