search

snoplusuk / echidna

MIT License
4 stars 12 forks source link

Remove getters / setters #138

Open mjmottram opened 8 years ago

mjmottram commented 8 years ago

This is just a proposal, but the getters and setters in echidna are not pythonic (see e.g. http://stackoverflow.com/questions/6618002/python-property-versus-getters-and-setters and http://stackoverflow.com/questions/2627002/whats-the-pythonic-way-to-use-getters-and-setters). I also find that they make reading the code difficult due to all the docstrings (which are just duplications of that the class members are anyway). I propose removing all getters and setters, and implementing @property decorators where it really is necessary to protect variables.

ashleyrback commented 8 years ago

Just to relay our discussions on Skype, yes I think this is a very good idea and would definitely condense the documentation so that only more essential documentation is present. However this is definitely a "nice-to-have", so I'm going to put it in the Future pipeline. Anyone is welcome to assign themselves and implement this if they have some spare time.