snoplusuk / echidna

MIT License
4 stars 12 forks source link

Seperate half life weights into its own function #28

Open jwaterfield opened 9 years ago

jwaterfield commented 9 years ago

Remove the half life weights from the fill_spectrum functions and have it in its own function which can be applied seperately.

Edit 15/04/2015: Jeanne's suggestion is to remove the timing axis from the Spectra class and have the timing applied as analytic function. This means that whenever you return a number of counts from the spectrum i.e. in Spectra.sum() you would need to multiply the number of events from the 2D spectrum by the result of the correct time model.

arushanova commented 9 years ago

I think we shouldn't do it. Realistically the best precision in time we can get counts in months or weeks(?), i.e. I doubt that anyone would want (would be able) to study the changes in spectra within days or hours. So what we can do is to 1) decide what would be a time unit: a week or a month 2) change the number of time bins from 10 years to 10_52.18 weeks or 10_12 months 3) fill the spectrum as we were doing it before

We have a function that slices spectrum, so it will be possible to study any time block.

jwaterfield commented 9 years ago

Timing will now be analytic

ashleyrback commented 8 years ago

I think this issue isn't actually relevant any more, since all spectral parameters are specified via config now. Are we happy to close this issue?