A couple of points relating to #36

snoplusuk / echidna

MIT License

4 stars 12 forks source link

Closed ashleyrback closed 9 years ago

ashleyrback commented 9 years ago

In combine_hdf5.py:

Would prefer use of argparse over sys.argv to keep it consistent with the other scripts.
Would also prefer use of argparse.error over print followed by sys.exit(1), see https://github.com/snoplusuk/echidna/blob/master/echidna/scripts/dump_smeared.py#L51 for an example
Typo on line 27, loads file1 twice

ashleyrback commented 9 years ago

@jwaterfield, nothing major. The only one that has to be done is the 3rd bullet, but the other two would be nice!

ashleyrback commented 9 years ago

closed by #41