search

snoplusuk / echidna

MIT License
4 stars 12 forks source link

Shift #89

Closed jwaterfield closed 8 years ago

jwaterfield commented 8 years ago

Added a class which shifts the values of a spectra variable. Requires #87 to be merged first.

ashleyrback commented 8 years ago

Failure on unittest:

======================================================================
FAIL: test_scale (test_scale.TestScale)
Tests the variable scaling method.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ashley/snoplus/software/echidna/echidna-pr/echidna/test/test_scale.py", line 86, in test_scale
    % (expected_sigma, sigma))
AssertionError: Expected sigma 0.22, fitted sigma 0.22284080161

----------------------------------------------------------------------

I think you just missed the import numpy in shift.py.

ashleyrback commented 8 years ago

and one minor pep8 error:

echidna/test/test_shift.py:112:1: W391 blank line at end of file
ashleyrback commented 8 years ago

Other than those two, looks good to merge!

jwaterfield commented 8 years ago

@ashleyrback Should be good to go now.

ashleyrback commented 8 years ago

Happy, merging!