snoplusuk / echidna

MIT License
4 stars 12 forks source link

Extractors #96

Open arushanova opened 9 years ago

arushanova commented 9 years ago

I'm going to use the limit setting part of echidna to look at how the pileup rejection helps improving the limit of 0nu. At the moment in order to create a spectra class I have to prepare the root file (i.e. apply the pileup cuts) first and then just to fill in an empty spectra with the energies. This leads to the question if we want to add more extractors? I've written the options I can see and comments below.

1) We will add more extractors. This extractors will be basically representing the cuts. I personally will need to implement about five extractors, that are the classifiers I use for cuts.

2) We are not adding more extractors. It is quite simple for a user to keep the code that prepares the pdf personal. In this case a person can apply any cuts before he turns his file into a spectra class.

jwaterfield commented 9 years ago

@arushanova I think its always useful to add a new extractor to echidna if you have written it and is not there already. Mainly because there is no way of knowing whether people will use it in the future even if you are the only one using it currently and a pull request means that your code will be checked by another person which will minimise the risk of any bugs in your analysis code. Plus everyone can pick and choose whatever extractors they want to use so if they dont want to use your one then they dont have to and it wont effect their spectra or how echidna interacts with the spectra (or echidnas speed) but if the extractor is in the main code then at the very least the person has the option to choose to use it which they wouldnt have if it werent in the main code.

ashleyrback commented 8 years ago

@arushanova does @mjmottram's #129 help here?