search

snopt / snopt-interface

C/C++ API for SNOPT7
MIT License
27 stars 12 forks source link

snopt_cwrap.h also interfaces with SNOPTA #20

Closed hongkai-dai closed 6 years ago

hongkai-dai commented 6 years ago

On top of snopt_cwrap.h, it says it's the C interface for SNOPTB and SNOPTC, but we also have solveA in snopt_cwrap.h. Should we change the documentation to include SNOPTA as well?

gnowzil commented 6 years ago

snoptA should be there as well. solve* were what I called the main solve routines initially, but I decided to "change" them to snopt* (but left solve* for backward compatibility).

jwnimmer-tri commented 6 years ago

I think the issue here is not that any function signatures are missing from the file, but rather that this comment atop the file is incomplete / misleading:

/* File: snopt_cwrap.h
 *   C interface for SNOPTB and SNOPTC.
 */
gnowzil commented 6 years ago

I understood what he said and my reply was "snoptA should be there as well". If the issue were anything more serious, I would've addressed it earlier.

What I say afterwards is based on OPs comment about using solveA. I'm just trying to point out that he should update his calls to snopt* rather than solve*.