snorkel-team / snorkel

A system for quickly generating training data with weak supervision

https://snorkel.org

Apache License 2.0

5.81k stars 857 forks source link

Model baseline model imports to snorkel/labeling/model #1535

Closed vincentschen closed 4 years ago

vincentschen commented 4 years ago

Description of proposed changes

snorkel/labeling/__init__.py contained extraneous imports for baseline models. Cleaning up dependencies by moving model imports to snorkel/labeling/model/__init__.py

Test plan

Ran tox + tox -e doc + tox -e complex

Checklist

Need help on these? Just ask!

[x] I have read the CONTRIBUTING document.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] I have run tox -e complex and/or tox -e spark if appropriate.
[x] All new and existing tests passed.

codecov[bot] commented 4 years ago

Codecov Report

Merging #1535 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1535   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          55       55           
  Lines        2052     2052           
  Branches      338      338           
=======================================
  Hits         2001     2001           
  Misses         23       23           
  Partials       28       28

vincentschen commented 4 years ago

@vincentschen looking good! Need to add model to https://github.com/snorkel-team/snorkel/blob/master/docs/packages.json to generate the doc pages!

Nice catch — Added!

~@henryre Also ran tox -e doc afterwards, but no additional chances. Should I expect the underlying _autosummary/.rst files to update?~ Fixed with tox -e fix!