snorkel-team / snorkel

A system for quickly generating training data with weak supervision
https://snorkel.org
Apache License 2.0
5.81k stars 857 forks source link

Upgrade pytorch requirement to >=1.2.0 #1565

Closed vincentschen closed 4 years ago

vincentschen commented 4 years ago

Description of proposed changes

Related issue(s)

Fixes https://github.com/snorkel-team/snorkel/issues/1558

Test plan

Checklist

Need help on these? Just ask!

codecov[bot] commented 4 years ago

Codecov Report

Merging #1565 into master will not change coverage by %. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1565   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files          56       56           
  Lines        2091     2091           
  Branches      342      342           
=======================================
  Hits         2031     2031           
  Misses         31       31           
  Partials       29       29           
Impacted Files Coverage Δ
...ssification/training/loggers/tensorboard_writer.py 100.00% <100.00%> (ø)
snorkel/classification/training/trainer.py 89.83% <100.00%> (ø)
snorkel/labeling/model/label_model.py 95.54% <100.00%> (ø)
snorkel/slicing/utils.py 94.66% <100.00%> (ø)
henryre commented 4 years ago

@vincentschen can we update the Test Plan with details from the multiple version tests?

vincentschen commented 4 years ago

@vincentschen can we update the Test Plan with details from the multiple version tests?

Yep! Naively, pinned the version to each minor release and ran all unit/integration tests.