Closed dchichkov closed 4 years ago
@dchichkov any luck on the type errors? feel free to assign a review once tests pass! the torch errors look independent (and shouldn't be push blocking).. will look into those separately
Merging #1584 into master will increase coverage by
0.06%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
+ Coverage 97.13% 97.19% +0.06%
==========================================
Files 56 68 +12
Lines 2091 2137 +46
Branches 342 343 +1
==========================================
+ Hits 2031 2077 +46
Misses 31 31
Partials 29 29
Impacted Files | Coverage Δ | |
---|---|---|
snorkel/map/core.py | 100.00% <0.00%> (ø) |
|
snorkel/preprocess/nlp.py | 86.66% <0.00%> (ø) |
|
snorkel/slicing/sf/nlp.py | 100.00% <0.00%> (ø) |
|
snorkel/types/__init__.py | 100.00% <0.00%> (ø) |
|
snorkel/labeling/lf/nlp.py | 100.00% <0.00%> (ø) |
|
snorkel/labeling/model/label_model.py | 95.54% <0.00%> (ø) |
|
snorkel/preprocess/__init__.py | 100.00% <0.00%> (ø) |
|
snorkel/types/hashing.py | 100.00% <0.00%> (ø) |
|
snorkel/labeling/model/__init__.py | 100.00% <0.00%> (ø) |
|
snorkel/__init__.py | 100.00% <0.00%> (ø) |
|
... and 9 more |
Description of proposed changes
Allow pandas up to and including 1.0.x
Related issue(s)
1583
Fixes # (issue)
1582
Test plan
Forked from master, c4e24fbd4b5ff4b9c64298ead2ca0f66d04819d5
tox -e py37 passes with:
tox -e complex fails with Torch errors, in the same way as with pandas 0.25.0:
Checklist
Need help on these? Just ask!
tox -e complex
and/ortox -e spark
if appropriate.