snorkel-team / snorkel

A system for quickly generating training data with weak supervision
https://snorkel.org
Apache License 2.0
5.81k stars 857 forks source link

Documentation issues #1592

Closed TrigonaMinima closed 4 years ago

TrigonaMinima commented 4 years ago

Description of proposed changes

Added documentation updates for the following:

Related issue(s)

Fixes #1585

Test plan

Not applicable

Checklist

Need help on these? Just ask!

TrigonaMinima commented 4 years ago

It's failing because of errors unrelated to my changes.

henryre commented 4 years ago

I'll take a look at the errors in CI as well. Looks like a version change for our linting tools.

TrigonaMinima commented 4 years ago

Regarding linting errors, one error was because someone has created the f strings where it's not required. I can fix them in this pull itself if it's fine.

henryre commented 4 years ago

@TrigonaMinima it looks like there are other linting issues due to a third party package update (possibly mypy itself). Looking into this today!

TrigonaMinima commented 4 years ago

Same linting errors unrelated to my changes.

henryre commented 4 years ago

@TrigonaMinima just landed linting fixes, so re-running your checks now!

codecov[bot] commented 4 years ago

Codecov Report

Merging #1592 into master will increase coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1592      +/-   ##
==========================================
+ Coverage   97.13%   97.17%   +0.04%     
==========================================
  Files          56       67      +11     
  Lines        2091     2126      +35     
  Branches      342      342              
==========================================
+ Hits         2031     2066      +35     
  Misses         31       31              
  Partials       29       29              
Impacted Files Coverage Δ
snorkel/labeling/model/label_model.py 95.54% <ø> (ø)
snorkel/labeling/model/__init__.py 100.00% <0.00%> (ø)
snorkel/utils/__init__.py 100.00% <0.00%> (ø)
snorkel/preprocess/__init__.py 100.00% <0.00%> (ø)
snorkel/slicing/__init__.py 100.00% <0.00%> (ø)
snorkel/labeling/__init__.py 100.00% <0.00%> (ø)
...norkel/classification/training/loggers/__init__.py 100.00% <0.00%> (ø)
snorkel/map/__init__.py 100.00% <0.00%> (ø)
snorkel/classification/__init__.py 100.00% <0.00%> (ø)
snorkel/slicing/sf/__init__.py 100.00% <0.00%> (ø)
... and 3 more
henryre commented 4 years ago

@TrigonaMinima if you're happy with the changes, I'll go ahead and merge this in

TrigonaMinima commented 4 years ago

@henryre yes we can go ahead with it.