Increase minimal supported scikit-learn version

snorkel-team / snorkel

A system for quickly generating training data with weak supervision

https://snorkel.org

Apache License 2.0

5.81k stars 857 forks source link

Increase minimal supported scikit-learn version #1613

Closed rth closed 3 years ago

rth commented 4 years ago

Currently snorkel requires scikit-learn <0.22, while the latest version if 0.23.2 with 0.24 on the way. As far as I can tell only scikit-learn imports are metric related modules and those should not change in a backward incompatible way.

It might be better to indicate <1.0 as an upper bound for scikit-learn. Scientific python packages don't follow semver anyway and put a lot of effort to not break backward compatibility (at least not without a deprecation cycle first).

brahmaneya commented 4 years ago

Hi @rth , we periodically update versions for dependencies. We can update the requirement to <0.24 in our next version. If you are in a hurry, feel free to send a PR to bump the version as well!

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.